feat: Improved initial prompt handling #142
Conversation
|
✅ Preview binaries are ready! To test with modules: |
hugodutka
left a comment
hugodutka
left a comment
There was a problem hiding this comment.
Please add a test in conversation_test.go to check if the new logic behaves correctly.
|
resolved all the comments. |
|
@mafredri resolved all the comments. |
| assert.Equal(t, st.ConversationStatusStable, c.Status()) | ||
| assert.False(t, c.ReadyForInitialPrompt) | ||
| assert.True(t, c.InitialPromptSent) | ||
| }) |
There was a problem hiding this comment.
It'd be nice to see one more test case where we test that initial prompt is false, goes to true, and then back to false after the initial prompt is actually sent.
It'd be fine to update one of the tests to be that but perhaps it's not easily tested.
I'll leave it up to you though.
| } | ||
| c := st.NewConversation(context.Background(), cfg, "initial prompt here") | ||
| // Manually mark as sent to simulate that initial prompt was already sent | ||
| c.InitialPromptSent = true |
There was a problem hiding this comment.
Is there a way to not do this manually? It's hard to say here whether we're testing that ready for initial prompt stays false the whole time or goes from true to false. I'm assuming it's the former but the latter has merit as a test. (See other comment).
3 participants
Example - Opencode agent:
The PR tries to fix this by taking into account whether the input box is visible or not.